Menu
▾
▴
#5323 sort input files
Started
None
needs_work
Enhancement
2018-06-10
2018-05-18
No
sort input files
to have reproducible link order
so that the lilypond binary always contains its functions in the same order.
When building packages (e.g. for openSUSE Linux)
(random) filesystem order of input files
influences ordering of functions in the output,
thus without the patch, builds (in disposable VMs) would differ.
See https://reproducible-builds.org/ for why this matters.
http://codereview.appspot.com/347770043
Diff:
Passes make, make check and a full make doc although the initial patch has some questions on Rietveld.
The questions on this still have not been resolved so am leaving this on review. @Bernhard can you look at the Rietveld comments please?
sorting .o files instead of .cc
http://codereview.appspot.com/347770043
Passes make, make check and a full make doc.
Patch on countdown for May 29th.
I am going to leave this on countdown for June 1 as there seems to be more needed (if only a clarification) looking at Rietveld.
Bernhard, can you look at the comment on the Rietveld please? I am not a programmer so I don't know if this is something from Dan that can be 'ignored' or 'explained' and the patch can be pushed.
Leaving on countdown for now.
Still no comment fom Bernhard re Rietveld. Leaving for one more countdown.
Setting down to review - no update about the Rietveld comment - I have posted a note there too. If tihs still has no decision by next countdown I will set this patch to needs_work.
This patch lookslike it still needs work - Dan Eble clarified his previous concern/comment on Rietveld for me.